Private to protected transition of getOpenSSLCtx method#1
Open
tsunday wants to merge 3 commits intoapache:3.9.xfrom
Open
Private to protected transition of getOpenSSLCtx method#1tsunday wants to merge 3 commits intoapache:3.9.xfrom
tsunday wants to merge 3 commits intoapache:3.9.xfrom
Conversation
added 3 commits
July 13, 2016 08:04
…nSSLContext within derived classes
…omasz.niedziela@motorolasolutions.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of the change
This small change allows to override default behaviour of OpenSSLContextSpi in derived classes. Base OpenSSLContexSpi was partially designed to allow overriding - see virtual methods like providerInit() or providerGetSocketFactory(). As for now ActiveMQ-Cpp doesn't support changing any of the cipher suites or protocol version used within OpenSSL secure connection. This fix allows users of the library to override default OpenSSLContextSpi with their own class. The main reason of changing the access level of getOpenSSLCtx method was the need of executing some of the openssl library functions on SSL_CTX object from derived class in overrided providerInit() method. Leaving this getter private prevents from changing any of the SSL_CTX parameters and makes derived classes useless.
Example usage